[SignalR]update default value for ClientCertEnabled #15006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @juniwang Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableLocalAuth Location: Microsoft.SignalRService/preview/2021-06-01-preview/signalr.json#L1948 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableAadAuth Location: Microsoft.SignalRService/preview/2021-06-01-preview/signalr.json#L1953 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableLocalAuth Location: Microsoft.SignalRService/preview/2021-06-01-preview/webpubsub.json#L2048 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableAadAuth Location: Microsoft.SignalRService/preview/2021-06-01-preview/webpubsub.json#L2053 |
|
| The resource 'PrivateLinkResource' does not have get operation, please add it. Location: Microsoft.SignalRService/preview/2021-06-01-preview/signalr.json#L1413 |
|
| The resource 'PrivateLinkResource' does not have get operation, please add it. Location: Microsoft.SignalRService/preview/2021-04-01-preview/signalr.json#L1413 |
|
| The resource 'PrivateLinkResource' does not have get operation, please add it. Location: Microsoft.SignalRService/preview/2021-06-01-preview/webpubsub.json#L1458 |
|
| The resource 'PrivateLinkResource' does not have get operation, please add it. Location: Microsoft.SignalRService/preview/2021-04-01-preview/webpubsub.json#L1453 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"signalr/resource-manager/readme.md",
"tag":"package-2021-06-01-preview",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"signalr/resource-manager/readme.md",
"tag":"package-2021-06-01-preview",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"signalr/resource-manager/readme.md",
"tag":"package-2021-06-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"signalr/resource-manager/readme.md",
"tag":"package-2021-04-01-preview",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"signalr/resource-manager/readme.md",
"tag":"package-2021-04-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"webpubsub/resource-manager/readme.md",
"tag":"package-2021-06-01-preview",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"webpubsub/resource-manager/readme.md",
"tag":"package-2021-06-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"webpubsub/resource-manager/readme.md",
"tag":"package-2021-04-01-preview",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"webpubsub/resource-manager/readme.md",
"tag":"package-2021-04-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=228268&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-signalr - 1.0.0b2❌azure-sdk-for-python-track2 - track2_azure-mgmt-webpubsub - 1.0.0b1️✔️azure-sdk-for-go - signalr/mgmt/2020-05-01/signalr - v55.4.0️✔️azure-sdk-for-go - signalr/mgmt/2018-10-01/signalr - v55.4.0️✔️azure-sdk-for-go - preview/signalr/mgmt/2021-06-01-preview/signalr - v55.4.0️✔️azure-sdk-for-go - preview/signalr/mgmt/2021-04-01-preview/signalr - v55.4.0️✔️azure-sdk-for-go - preview/signalr/mgmt/2020-07-01-preview/signalr - v55.4.0️✔️azure-sdk-for-go - preview/signalr/mgmt/2018-03-01-preview/signalr - v55.4.0️✔️azure-sdk-for-go - preview/webpubsub/mgmt/2021-06-01-preview/webpubsub - v55.4.0️✔️azure-sdk-for-go - preview/webpubsub/mgmt/2021-04-01-preview/webpubsub - v55.4.0️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/signalr/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/webpubsub/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.SignalR [View full logs] [Release SDK Changes]️✔️Microsoft.Azure.Management.WebPubSub [View full logs] [Release SDK Changes]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-signalr [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Model SignalRResource has a new parameter disable_aad_auth info [Changelog] - Model SignalRResource has a new parameter disable_local_auth info [Changelog] - Model SignalRResource has a new parameter public_network_access
️✔️track2_azure-mgmt-webpubsub [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Model WebPubSubResource has a new parameter disable_aad_auth info [Changelog] - Model WebPubSubResource has a new parameter diagnostic_configuration info [Changelog] - Model WebPubSubResource has a new parameter disable_local_auth info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Model WebPubSubResource no longer has parameter features
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-07-15 05:47:38 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-signalr;1.0.0-beta.2;1.0.0-beta.3" cmderr [generate.py] 2021-07-15 05:47:38 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3" cmderr [generate.py] 2021-07-15 05:47:38 INFO autorest --version=3.4.5 --use=@autorest/java@4.0.32 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/signalr/azure-resourcemanager-signalr --java.namespace=com.azure.resourcemanager.signalr --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/signalr/resource-manager/readme.md cmderr [generate.py] 2021-07-15 05:48:08 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-signalr cmderr [generate.py] 2021-07-15 05:48:08 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-07-15 05:48:08 INFO [POM][Skip] pom already has module azure-resourcemanager-signalr cmderr [generate.py] 2021-07-15 05:48:08 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-07-15 05:48:08 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-07-15 05:48:08 INFO [POM][Skip] pom already has module sdk/signalr cmderr [generate.py] 2021-07-15 05:48:08 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-signalr [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-signalr-1.0.0-beta.3-sources.jar
- azure-resourcemanager-signalr-1.0.0-beta.3-javadoc.jar
- azure-resourcemanager-signalr-1.0.0-beta.3.jar
cmderr [Inst] 2021-07-15 05:50:12 DEBUG Got artifact_id: azure-resourcemanager-signalr cmderr [Inst] 2021-07-15 05:50:12 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-07-15 05:50:12 DEBUG Got artifact: azure-resourcemanager-signalr-1.0.0-beta.3-sources.jar cmderr [Inst] 2021-07-15 05:50:12 DEBUG Got artifact: azure-resourcemanager-signalr-1.0.0-beta.3-javadoc.jar cmderr [Inst] 2021-07-15 05:50:12 DEBUG Got artifact: azure-resourcemanager-signalr-1.0.0-beta.3.jar cmderr [Inst] 2021-07-15 05:50:12 DEBUG Match jar package: azure-resourcemanager-signalr-1.0.0-beta.3.jar cmderr [Inst] 2021-07-15 05:50:12 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15006/azure-sdk-for-java/azure-resourcemanager-signalr/azure-resourcemanager-signalr-1.0.0-beta.3.jar\" -o azure-resourcemanager-signalr-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-signalr -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-signalr-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true ```"}️✔️azure-resourcemanager-webpubsub [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-webpubsub-1.0.0-beta.2-sources.jar
- azure-resourcemanager-webpubsub-1.0.0-beta.2.jar
- azure-resourcemanager-webpubsub-1.0.0-beta.2-javadoc.jar
cmderr [Inst] 2021-07-15 05:51:32 DEBUG Got artifact_id: azure-resourcemanager-webpubsub cmderr [Inst] 2021-07-15 05:51:32 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-07-15 05:51:32 DEBUG Got artifact: azure-resourcemanager-webpubsub-1.0.0-beta.2-sources.jar cmderr [Inst] 2021-07-15 05:51:32 DEBUG Got artifact: azure-resourcemanager-webpubsub-1.0.0-beta.2.jar cmderr [Inst] 2021-07-15 05:51:32 DEBUG Match jar package: azure-resourcemanager-webpubsub-1.0.0-beta.2.jar cmderr [Inst] 2021-07-15 05:51:32 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15006/azure-sdk-for-java/azure-resourcemanager-webpubsub/azure-resourcemanager-webpubsub-1.0.0-beta.2.jar\" -o azure-resourcemanager-webpubsub-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-webpubsub -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-webpubsub-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true ```"}
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/signalr/resource-manager/readme.md command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/webpubsub/resource-manager/readme.md
️✔️@azure/arm-signalr [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/signalRManagementClient.js → ./dist/arm-signalr.js... cmderr [npmPack] created ./dist/arm-signalr.js in 300ms
️✔️@azure/arm-webpubsub [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/webPubSubManagementClient.js → ./dist/arm-webpubsub.js... cmderr [npmPack] created ./dist/arm-webpubsub.js in 317ms
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️signalr/mgmt/2020-05-01/signalr [View full logs] [Release SDK Changes]info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] ### New Content info [Changelog] info [Changelog] - New function `ResourceSku.MarshalJSON() ([]byte, error)` info [Changelog] - New function `CreateOrUpdateProperties.MarshalJSON() ([]byte, error)` info [Changelog] info [Changelog] Total 0 breaking change(s), 2 additive change(s). info [Changelog]
️✔️signalr/mgmt/2018-10-01/signalr [View full logs]info [Changelog] No exported changes
️✔️preview/signalr/mgmt/2021-06-01-preview/signalr [View full logs]info [Changelog] No exported changes
️✔️preview/signalr/mgmt/2021-04-01-preview/signalr [View full logs]info [Changelog] No exported changes
️✔️preview/signalr/mgmt/2020-07-01-preview/signalr [View full logs]info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] ### New Content info [Changelog] info [Changelog] - New function `ResourceSku.MarshalJSON() ([]byte, error)` info [Changelog] info [Changelog] Total 0 breaking change(s), 1 additive change(s). info [Changelog]
️✔️preview/signalr/mgmt/2018-03-01-preview/signalr [View full logs]info [Changelog] No exported changes
️✔️preview/webpubsub/mgmt/2021-06-01-preview/webpubsub [View full logs]info [Changelog] No exported changes
️✔️preview/webpubsub/mgmt/2021-04-01-preview/webpubsub [View full logs]info [Changelog] No exported changes
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️signalr [View full logs] [Release Schema Changes]
juniwang
changed the title
|
Hi @juniwang, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Jun 28, 2021
This was referenced Jun 28, 2021
This was referenced Jun 28, 2021
juniwang
added
the
WaitForARMFeedback
|
Note: this needs to complete the breaking change review and get signoff before ARM review. |
|
Hi Chris, the intake https://msazure.visualstudio.com/One/_workitems/edit/10294299 is in state Approved, does it mean the change is approved? or do I need to ping breaking change reviewers? |
Actually, I'm not sure. Can you ping azbreakchangereview with me on the to: line and ask? I thought normally, the label should be removed by the breaking change reviewer(s), but it hasn't in this case. |
JeffreyRichter
added
the
Approved-BreakingChange
mentat9
added
ARMSignedOff
|
Thanks Jeffrey and Chris. |
leni-msft
approved these changes
Jul 15, 2021
This was referenced Jul 15, 2021
Closed
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Fix Swagger Correctness issue
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.